search

alphazframework / framework

Core files of AlphaZ Framework
https://alphazframework.github.io/
MIT License
16 stars 17 forks source link

Added RSA key generation supports #299

Closed lablnet closed 4 years ago

lablnet commented 5 years ago

Added support of Generate RSA keypair

@peter279k what do you think?

codecov[bot] commented 5 years ago

Codecov Report

Merging #299 into master will increase coverage by 0.12%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #299      +/-   ##
============================================
+ Coverage     10.06%   10.19%   +0.12%     
- Complexity     1927     1928       +1     
============================================
  Files           112      112              
  Lines          4867     4874       +7     
============================================
+ Hits            490      497       +7     
  Misses         4377     4377
Impacted Files Coverage Δ Complexity Δ
src/Site/Key.php 100% <100%> (ø) 5 <1> (+1) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 473f69c...30c5ed3. Read the comment docs.

peter279k commented 5 years ago

Consider this post, and I think we don't only use RSA.

It should use Hybrid RSA+AES encryption or other encryption approaches.

lablnet commented 5 years ago

AES

I thought we can use two approaches here

first generate RSA keypair Other is generate RSA+AES Hybrid combinations, so it will be upon user choose which to use....

what do you think?

peter279k commented 5 years ago

IMHO, using the hybrid RSA + AES encryption instead.

And don't use only RSA encryption approach.

lablnet commented 4 years ago

This PR is now closed, will create new PR regarding this.