alsoscotland / react-super-select

MIT License
95 stars 33 forks source link

componentWillReceiveProps has been renamed, and is not recommended for use #168

Open krtschmr opened 4 years ago

krtschmr commented 4 years ago

<ReactSuperSelect initialValue={this.initialValue()} customOptionTemplateFunction={this.bankTemplate} placeholder={"Select the receiving bank"} dataSource={this.props.banks} onChange={this.changeHandler} clearable={false}/>

results in

}
react-dom.development.js:12430 Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

* Move data fetching code or side effects to componentDidUpdate.
* If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
* Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: ReactSuperSelect
alsoscotland commented 4 years ago

@krtschmr Thanks for filing the issue. At the moment I do not have the bandwidth to update this component.

krtschmr commented 4 years ago

@alsoscotland that's okay. i'm too much of a beginner to understand what's going on in react, so i can't patch/fix it and just report. as long it's in here, so we know it and can address it in future, we are all happy.