search

alsoscotland / react-super-select

MIT License
95 stars 33 forks source link

Updating control id to accept id as prop #85

Closed oyeanuj closed 7 years ago

oyeanuj commented 7 years ago

In order to fix #46 for those doing server side rendering, now the control id can accept an id as a prop instead of relying on dynamic key generation (which then led to a mismatch between the server and the client).

alsoscotland commented 7 years ago

@oyeanuj Thanks. I will implement something similar but I'd want to use a prop name other than just id. I will make an update soon that does this

oyeanuj commented 7 years ago

@alsoscotland sounds good, looking forward to it!

(alternatively, if it takes load off your plate, i'll be happy to rename it to your preference and update the PR).

alsoscotland commented 7 years ago

@oyeanuj https://github.com/alsoscotland/react-super-select/tree/v0.5.8