search

altercation / solarized

precision color scheme for multiple applications (terminal, vim, etc.) with both dark/light modes
http://ethanschoonover.com/solarized
MIT License
15.82k stars 3.52k forks source link

xfce terminal support for solarized is baked into xfce4-terminal now; it should be removed? #322

Open nfirvine opened 9 years ago

nfirvine commented 9 years ago

http://git.xfce.org/apps/xfce4-terminal/commit/colorschemes/solarized-light.theme.in?id=0aab08157c72b4b76587cf89f8d4f1f235f2da24

Especially considering upstream is unmaintained: https://github.com/sgerrand/xfce4-terminal-colors-solarized/issues/11

nfirvine commented 9 years ago

As per https://github.com/sgerrand/xfce4-terminal-colors-solarized/issues/11, @sgerrand is still around.

TrevorBramble commented 9 years ago

@nfirvine Is that the intended URL? I don't see anything relevant. We should probably keep the port around for people who run earlier XFCE versions...

nfirvine commented 9 years ago

@TrevorBramble No, it wasn't; updated. May it would be useful to add a notes somewhere that mentions that it's baked into new XFCEs and is also incompatible. Not sure where that's appropriate.

egmontkob commented 6 years ago

Let's also note that xfce4-terminal/light/terminalrc is broken: ColorPalette5's green channel is incorrect, plus entries 11-12 and 13-15 are swapped. One more reason to retire it here.