search

altercation / solarized

precision color scheme for multiple applications (terminal, vim, etc.) with both dark/light modes
http://ethanschoonover.com/solarized
MIT License
15.82k stars 3.52k forks source link

Pull request to update README.md #418

Closed dampdigits closed 11 months ago

dampdigits commented 11 months ago

Hello there @weakish , I have used your gist for Roxterm Solarized theme & found it helpful. However, I propose to make some grammatical improvements and spelling corrections to your README.

This would probably be my first contribution, though it's not an improvement of code but I'm taking small steps in the world programming.

shibor commented 11 months ago

我应经收到你的邮件！

dampdigits commented 11 months ago

我应经收到你的邮件！

A reply in english would have been much better, but why would you receive my email?

weakish commented 11 months ago

I propose to make some grammatical improvements and spelling corrections

Thanks a lot for fixing typos. I merged your commits. :tada:

I'm taking small steps in the world programming.

Welcome aboard. I moved the gist to github repo, so filing issues and pull requests will be more convenient.

but why would you receive my email

I guess shibor subscribes to new issues of this repo (altercation/solarized) and the reply is an auto-reply from their email provider automatically trigged when a new email (in this case, GitHub notification email) is received in their inbox. And GitHub will automatically convert replies to notification email to issue replies.

dampdigits commented 11 months ago

I guess shibor subscribes to new issues of this repo (altercation/solarized) and the reply is an auto-reply from their email provider automatically trigged when a new email (in this case, GitHub notification email) is received in their inbox. And GitHub will automatically convert replies to notification email to issue replies.

Understood, and thanks for the merge : )