feat(everything): Automatically assign controller and headset info based on the client-provided string

alvr-org / ALVR

Stream VR games from your PC to your headset via Wi-Fi

MIT License

5.57k stars 495 forks source link

feat(everything): Automatically assign controller and headset info based on the client-provided string #2453

Closed shinyquagsire23 closed 3 weeks ago

shinyquagsire23 commented 1 month ago

Adds Quest Pro controller models to SteamVR backend (and an override option for that)
Move alvr_client_core::platform to alvr_common so it can be used in server_core
Allow parsing Platform from its to_string() value, to allow Platform usage in server_core when the client connects
A bit of simplification on the OpenVR properties, specifically grouping common icon settings into a separate match statement so it isn't duplicated 4 times for Quest/Rift controllers

zmerp commented 1 month ago

There are quite a few compilation errors here. First of all we should discuss if moving the platform to the common crate is a good idea. My initial idea was no, because you are adding more dependencies to alvr_common. But on second through i think it's ok. The only dependencies are jni and ndk_context and these can be gated to android. I'd say as a fist step, you should move all Platform related stuff to alvr_common, in another PR. Then when merged we rebase this one.

zmerp commented 1 month ago

I'm going to move the platform stuff to a new crate alvr_system_info, once the the queue of PRs got cleared up a bit

shinyquagsire23 commented 3 weeks ago

gonna go ahead and close this and do it a bit more piecewise (ie, Quest Pro controller PR)