search

alvr-org / alvr-visionos

Experimental visionOS client for ALVR - SteamVR on Apple Vision Pro!
MIT License
432 stars 31 forks source link

Update ALVR submodule to use alvr_get_settings_json() #48

Closed sidd closed 9 months ago

sidd commented 9 months ago

Updated ALVR submodule to point to latest ALVR commit. This required some changes, most notably foveation config is no longer sent in the StreamingStarted event. Now, we consume settings from the newly added alvr_get_settings_json().

I partially adapted Switch<C> from ALVR core to a Swift enum, so it can be reused for other settings. Could also use JSONSerialization instead if people prefer.

sidd commented 9 months ago

Thanks! I'll clean this up per your suggestion.

zmerp commented 9 months ago

I fixed AlvrPose not exposed in the generated header upstream. Also I tweaked the AlvrDeviceMotion definition. So this PR needs rebasing

sidd commented 9 months ago

@shadowfacts let me know if you’d like to see any further changes. Feel free to reach out on Discord too, I’m open to any suggestions.

zmerp commented 9 months ago

The PR needs rebasing

shinyquagsire23 commented 9 months ago

oh oops I forgot to comment. tested and confirmed working before merging