search

alyssafrazee / polyester

Bioconductor package "polyester", devel version. RNA-seq read simulator.
http://biorxiv.org/content/early/2014/12/12/006015
89 stars 51 forks source link

bugfix - avoids duplicated read IDs #51

Closed vllorens closed 6 years ago

vllorens commented 6 years ago

Hi, as I commented on #50, I tested yesterday the sgseq.R function and found out that the problem comes from adding 1e6 to the offset value in the interations loop, as in each iteration it was creating 1000001 reads instead of 1e6. Changing the value for 999999 does the trick to avoid extra reads with duplicated IDs.

alyssafrazee commented 6 years ago

thank you so much for fixing this with a pull request!! very much appreciated. going to merge in a moment -- @JMF47, could you make sure this gets pushed out to BioC?

ajw2329 commented 5 years ago

In case other users encounter this the fix does not appear to be on BioC as of 1.18.