Closed roshii closed 7 years ago
btw, this reduce image size by 20% :)
Btw probably should have mentioned this in the last pr, but you can just run make update
to regenerate all the dockerfiles.
Thanks for the PR! This is a good idea in general.
Let me know when you have addressed above feedback, and either run make update
to refresh all the docker images, or just make
to refresh and build/test everything locally.
Thanks once again
I'll amend the erb and run make update
whithin 6 hours (can't do this from work...)
I will most likely submit a new pull request by then to make it cleaner.
Sounds good. No need to make a separate PR, just add more commits and we can squash this one down when I merge it.
On Thu, Jul 6, 2017, 2:41 AM roshii notifications@github.com wrote:
Thanks once again I'll amend the erb and run make update whithin 6 hours (can't do this from work...) I will most likely submit a new pull request by then to make it cleaner.
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/amacneil/docker-bitcoin/pull/20#issuecomment-313348355, or mute the thread https://github.com/notifications/unsubscribe-auth/AAm659zqGMIFOZElUBPbPpbVnGqPkQgMks5sLKu5gaJpZM4OO2fV .
Sorry, I couldn't work on this yesterday but shall be able to do this over the weekend. Cheers
looks good now :)
Thanks!
Changed dockerfile.erb, guessing youll use the erb to generate all the other dockerfile Also changed the one for the version im interested in runin: tested and runing fine >https://hub.docker.com/r/r0shii/bitcoin/builds/