amaximus / garbage-collection-card

Custom Lovelace card for Garbage Collection custom component
MIT License
127 stars 24 forks source link

Icons Missing #84

Closed bkr1969 closed 1 year ago

bkr1969 commented 2 years ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior Has worked perfectly, but today, my garbage collection date, there is no icon at all. Everything else is there, just no icon.

Screenshots If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

Additional context Add any other context about the problem here.

bkr1969 commented 2 years ago

Now the trash icon is back, but no recycle icon. Both configured the same apart from the actual icon.

amaximus commented 2 years ago

Testing the newest version of the card newest HA Core the recycle button is visible (pls see attached). Maybe you'll have to clear your browser cache and reload the page.

Some user reported that restarting supervisor also helped. I'm not using the supervisor mode installation, but the simple HA Core (python virtual env), so I do not know what influence supervisor has on the frontend. f72c1520-7ad2-492d-ab0a-0c2aa23c45d0

bkr1969 commented 2 years ago

They seem to be randomly coming and going. There is nothing in the logs. I don't think it's version related as it started yesterday when I updated to 2021.11.2, but I have since gone back to 2021.10-6 and still have the problem.

amaximus commented 2 years ago

I'd say it's either a browser caching issue or some other component (supervisor?), but it's definitely not the card.

bkr1969 commented 2 years ago

I don't think it's browser related as it's the same problem in the app. Is there any way to dig into the supervisor and troubleshoot this?

amaximus commented 2 years ago

I'm not familiar with the Supervisor as I'm using the HA core installation.

mickeynygaard commented 2 years ago

I have the exact same issue. I've tried everything in regards to reconfiguring sensors, templates, etc...I had originally not updated to 2021.11.2 but just did and that made no difference...same experience, Icon is missing, in fact, most of the card is missing for me,...seems that if I by accident click the card, it...disappears?

amaximus commented 2 years ago

@mickeynygaard you may set hide_on_click to false.

mickeynygaard commented 2 years ago

@mickeynygaard you may set hide_on_click to false.

I could do that, but still I have no icons… I’ve tried both the 09 HA, the 11, and both 2.0 and 1.9 of the card… I really did nothing and it just stopped working, really strange

bkr1969 commented 2 years ago

They have never returned for me.

mickeynygaard commented 2 years ago

They have never returned for me.

Maybe we can find something we have in common that’ll help the troubleshooting?

amaximus commented 2 years ago

I have a HA Core installation where I cannot reproduce the fault. Some users reported the issue in a setup with supervisor. Some even mentioned that restarting the supervisor helped. I'm not familiar with the supervisor, what's its role, so I do not know how it would relate to the frontend.

mickeynygaard commented 2 years ago

I’m running core as well, docker instance, so no supervisor for me sadly…

bkr1969 commented 2 years ago

Restarting supervisor does nothing for me.

arigit commented 2 years ago

I noticed the same problem on 2011.11.4, the missing icon issue is only on the android app in my case. When accessing from two different laptops, the icons are still there (perhaps they got cached from before the update to 2021.11). Restarting the app, cleaning cache etc, is not fixing the problem Also using Core, on docker on RPi4

amaximus commented 2 years ago

Just double-checked again both on a laptop running Windows 10 with Chrome 96.0.4664.45 and on an Android 10 mobile with HomeAssistant app and they both show the icon.

screenshot Screenshot_20211119-115346

There must be some other aspect that is common for your setups that causes this behaviour.

mickeynygaard commented 2 years ago

I Just tried adding a couple of cards with only the bare minimum of configuration... The "Genbrug" (recycle) one showed an icon initially but now it's gone...Genbrug still shows a date and next time emptied, but the one for normal garbage is just a blank...

image

Are there country specific files that may be at fault? I'm from Denmark if that matters at all

amaximus commented 2 years ago

These are not country specifics. It would be good to know at least one of your card's config. Please also note that this card is for sensors of custom integration Garbage Colection as it expects states and attributes created by that integration.

mickeynygaard commented 2 years ago

So I think the sensor I use is a bit different but I tried adding the Gar image image image image

I downgraded the card to 1.19 earlier in a troubleshooting attempt...just updated to 1.20 and now it seems like it works...very strange :|

Thank you for your help Amaximus

bkr1969 commented 2 years ago

I'm on 1.2 and mine do not show.

amaximus commented 2 years ago

@bkr1969 when you mention 1.2, which component were you refering to? The latest versions are:

bkr1969 commented 2 years ago

1.2 = 1.20.0 for the card. I am on the latest version of everything except Core is still 2021.10.6 because 2021.11.xx breaks one of my Tuya lights and no one has been able to tell me why.

amaximus commented 2 years ago

@bkr1969 could you please provide both the sensor and the card configuration?

Icon handling was changes in HASS 2021.11, that was addressed in version 1.20.0 of the card [1] If you are on 2021.10.x I'd recommend using version 1.19.0 of the card.

[1] https://github.com/amaximus/garbage-collection-card/releases/tag/1.20.0

arigit commented 2 years ago

@amaximus I am using 2021.11.4, icons gone in the android app. Was working perfectly up to 2021.10.x Card version 1.20.0

I tried downgrading to 1.19, same problem.

Card configuration:

                - type: custom:garbage-collection-card
                  name: Organics
                  entity: sensor.garbage_collection_organics
                  title_size: 11px
                  icon_size: 35px
                  icon_color: green
                - type: custom:garbage-collection-card
                  name: Garbage
                  entity: sensor.garbage_collection_garbage
                  title_size: 11px
                  icon_size: 35px
                  icon_color: grey
                - type: custom:garbage-collection-card
                  name: Recyclables
                  entity: sensor.garbage_collection_recyclables
                  title_size: 11px
                  icon_size: 35px
                  icon_color: blue

Integration configuration

image

image

I tried removing all my customization from the card, and it didn't help. In the integration, I tried removing the icon strings, saving and reloading, it didn't help either.

amaximus commented 2 years ago

@arigit Card version 1.20.0 should work with 2021.11.x while card version 1.19.0 should work with versions prior to 2021.11.x.

By android app do you mean the official Home Assistant app [2], right? Are you using the latest version of the android app? Do the icons appear on the card in a web browser session?

[2] https://play.google.com/store/apps/details?id=io.homeassistant.companion.android

bkr1969 commented 2 years ago

So maybe I just need version 1.19 since I’m not upping core to 2021.11.xx yet. How to I roll that back?

amaximus commented 2 years ago

@bkr1969 you may download file [3] and place it in ${HOME_ASSISTANT_CONF}/www/community/garbage-collection-card directory and remove the garbage-collection-card.js.gz file.

[3] https://github.com/amaximus/garbage-collection-card/blob/1.19.0/dist/garbage-collection-card.js

arigit commented 2 years ago

@amaximus yes this is on the Android app, latest version pushed to the play store (2011.10), on android 12 (Pixel 6), I did not have any issue on my browsers (firefox on both linux and mac). I could solve the problem with the app though and make the icons re-appear, here's how:

that solved the issue for me. Weirdly enough, only the icons of the garbage-collectio-card were missing, all of the other cards were fine.

amaximus commented 2 years ago

@arigit thanks for the detailed workaround steps. This issue seemes an android application caching issue.

mileyceberus commented 2 years ago

I also have the same issue where the icons don't appear regardless of browser type (firefox, safari, mobile, desktop). Refreshed and cleared the caches several times to no avail.

Garbage Collection Card - 1.17.2 - 1.20.0 Garbage Collection - 3.20 HACS - 1.16.0 Home Assistant - 2021.6.5

Screenshot below.

Screen Shot 2021-12-07 at 5 04 43 pm
amaximus commented 2 years ago

@mileyceberus have you tried restarting the Supervisor? Some users reported that it fixed the icon issue. In a plain HA Core installation there is no Supervisor and the issue doesn't appear pointing to a caching issue in another component (I don't know what's the role of Supervisor and what are its effects on UI).

Try to restart the Supervisor and get back to me with results.

mileyceberus commented 2 years ago

I have actually been restarting HA every time I installed a different version of your card. In any case, I have just restarted HA again and still cannot see the icons (firefox, safari, desktop, iphone, ipad).

Interestingly, I can see the outline of the icon when I click on one of the garbage sensors (see below),

Screen Shot 2021-12-07 at 7 47 01 pm

I am not sure if the icons were broken after upgrading bruxy70's sensors as nothing is shown on the logs.

amaximus commented 2 years ago

@mileyceberus Could you please upgrade HomeAssistant to latest? Version 1.20.0 of the card supports icons as per 2021.11 (there were some changes in this release related to how icons are handled). If you don't want to upgrade HASS to 2021.11.x please downgrade the card to 1.19.0 [1]. That version supports the way icons are handled in HASS prior to 2021.11.

[1] https://github.com/amaximus/garbage-collection-card/releases/tag/1.19.0

mileyceberus commented 2 years ago

I'll upgrade HA to the latest version assuming that it's fixed the issue with Xiaomi sensors.

PS. I installed every version of your card (1.17.2 - 1.20.0) but couldn't get the icons to display. Was working perfectly previously.

mileyceberus commented 2 years ago

Thanks, the icons are visible on desktop(s) and iPad(s) when I upgraded HA to 2021.11.5. However, they are missing on my iPhone(s). Unsure if this is a frontend HA bug or not (https://github.com/home-assistant/frontend/issues/9956).

pwae commented 2 years ago

With 2021.12.9 I'm seeing the same as what @mileyceberus did in this comment I use https://github.com/mampfes/hacs_waste_collection_schedule with a custom feed. The icon itself shows up on the entities list (see below), but not on the lovelace ui with this card (second screenshot below).

Screenshot_20220117_005223 Screenshot_20220117_005244

Card Config:

      - type: custom:garbage-collection-card
        entity: sensor.next_recycling_collection
        icon_size: 25px
        icon_color: '#dbdb6b'
        hide_before: 6
        hide_date: true
      - type: custom:garbage-collection-card
        entity: sensor.next_garbage_collection
        icon_size: 25px
        icon_color: blue
        hide_date: true
      - type: custom:garbage-collection-card
        entity: sensor.next_green_collection
        icon_size: 25px
        icon_color: green
        hide_before: 6
        hide_date: true
amaximus commented 2 years ago

@pwae please note that this card - as mentioned at the beginning of the Readme - relies on garbage collection custom component [1], meaning that expects state value and attributes as provided by [1].

When used with [1] the card works as expected:

garbage

[1] https://github.com/bruxy70/Garbage-Collection/

pwae commented 2 years ago

@pwae please note that this card - as mentioned at the beginning of the Readme - relies on garbage collection custom component [1], meaning that expects state value and attributes as provided by [1].

Apologies. the other addon said it supposed this card as well. But i've noticed it does, but with some additional work that i missed before. So I'll sort that out.

Thanks and apologies again!