Closed Yash-10 closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
ecce2bc
) to head (1b85446
). Report is 15 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issue #13:
Description of changes:
ArrayVar
intypes.py
, thedimensions
keyword argument is no longer required but inferred from the initial expression. The initial expression, however, becomes a necessary argument following the comments made on the issue.args[0]
is used because_ClassicalVar
inoqpy
'sArrayVar
suggestsinit_expression
is the first argument.Testing done: Yes.
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
args
andkwargs
, which remain unchanged?Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.