amazon-ion / ion-java-benchmark-cli

Apache License 2.0
7 stars 9 forks source link

Refactoring and updating data generating methods. #34

Closed linlin-s closed 2 years ago

linlin-s commented 2 years ago

Description of changes:

Motivation: This PR extracted the process of understanding ion schema out of data generating and data writing processes. Before refactoring, the method of extracting information out of ion schema file is to load the ion schema file to IonReader and then iterate the element until we find the target constraints. And this process also followed by data generating which makes adding new features of processing constraints complicated. After refactoring, supporting new features process will only contain two steps:

Commits:

  1. Adds package to process ion schema file:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

linlin-s commented 2 years ago

Encapsulating the schema-related logic is an improvement. A few comments below.

The updates from these comments are included in this commit: Updates PR based on the suggestions from comments.