amazon-science / tgl

Apache License 2.0
192 stars 31 forks source link

Parallel Temporal Sampler logic question #21

Closed zimengzhou1 closed 1 year ago

zimengzhou1 commented 1 year ago

Hi,

I'm not sure if this is the right place to ask, but in the sampler if we perform multi-layer sampling, and the current layer is not the first one, why are we doing binary search in each snapshot to find each root node instead of using the pointer array like in the initial layer?

tedzhouhk commented 1 year ago

Hi, thanks for your interest in our work. For multiple layers, the neighbors to sample may not be from the current timestamp. Say at time t, we have n1 at time t1<t as a neighbor for the root node n0. Then, for n1, we want the neighbors to be sampled until time t1 but not the current time t which is pointed by the pointer array. However, this is a design choice in the sampler. Feel free to modify to meet your needs.

zimengzhou1 commented 1 year ago

Thanks for explaining!