search

amber-smalltalk / amber-website

Amber's website (http://amber-lang.net)
2 stars 3 forks source link

update trysmalltalk to amber 0.14.3 #25

Closed tomrake closed 9 years ago

tomrake commented 9 years ago

Merge of this PR will change the LIVE amber-lang.org website!!! See https://tomrake.github.io/ to preview what these changes.

Things I note 1) Try Smalltalk in your browser will include the TrySmalltalk classes in the window it opens 2) Added a version to learn.html based on methods of https://github.com/amber-smalltalk/amber-website/pull/22

Please review and see if these changes are acceptable for the live site.

This should close #24

Most of the changes in the PR are dependencies in bower_components.

ghost commented 9 years ago

Two small issues:

tomrake commented 9 years ago

On node_modules, I made the assumption that because I used npm install to create the gh-pages branch and that branch is essentially served by github for amber-lang.org that the node_modules are necessary and should not be in .gitignore. I will test removal at https://tomrake.github.io/ and see if I get an error.

On version tags There are no version tags for amber-smalltalk/trysmalltalk I agree version tags, would be best.

hhzl commented 9 years ago

Minor thing: https://tomrake.github.io/learn.html should have

 copyright 2011-2015

note.

On 1/23/15, Tom Rake notifications@github.com wrote:

On node_modules, I made the assumption that because I used npm install to create the gh-pages branch and that branch is essentially served by github for amber-lang.org that the node_modules are necessary and should not be in .gitignore. I will test removal at https://tomrake.github.io/ and see if I get an error.

On version tags There are no version tags for amber-smalltalk/trysmalltalk I agree version tags, would be best.

Reply to this email directly or view it on GitHub: https://github.com/amber-smalltalk/amber-website/pull/25#issuecomment-71212577

ghost commented 9 years ago

You only need npm modules to run the tooling, on your machine. To run in browser, amber only needs things in bower_components when in devel mode, and even those can be eschewed in deploy mode, as there you only need the .html and the.js.

hhzl commented 9 years ago

Tom, thank you for working on this.

Preferrably we only should have the deployment version of 'the.js' and 'index.html' in the gh-pages branch.

No npm modules, no bower_components.

But I do not mind if for 0.14.3 we still have bower_components to not further delay the announcment of 0.14.3.

On 1/23/15, Herbert Vojčík notifications@github.com wrote:

You only need npm modules to run the tooling, on your machine. To run in browser, amber only needs things in bower_components when in devel mode, and even those can be eschewed in deploy mode, as there you only need the .html and the.js.

Reply to this email directly or view it on GitHub: https://github.com/amber-smalltalk/amber-website/pull/25#issuecomment-71244034

tomrake commented 9 years ago

node_modules are not needed to run the site. I added a README.md mainly to remind me what to do the next time. Once again see it at https://tomrake.github.io/ before making it go live on the site.

hhzl commented 9 years ago

Good to have the addition in the README.

hhzl commented 9 years ago

In 2014 we had the move to the new amber init type of project style. Quite a substantial change.

ghost commented 9 years ago

Was it in 2014 already (I mean the website; I hope I am not totally off and the copyright notice is for the website (it's a question for what it is, though, hm...))? Than yes, I would write 2011, 2014-2015. And if it is for Amber itself, then of course 2011-2015 is correct.

ghost commented 9 years ago

Ah, I see, this is trysmalltalk demo page. So it is for that.