search

ambuda-org / ambuda

Main application code for Ambuda, a breakthrough Sanskrit library (ambuda.org)
https://ambuda.org
MIT License
91 stars 24 forks source link

Verses vanish upon click when offline #346

Closed suhasm closed 2 years ago

suhasm commented 2 years ago

To reproduce:

  1. Open https://ambuda.org/texts/ramayanam/1.1
  2. Go offline
  3. Click on topmost verse. You'll see it vanish. If you click the now-topmost verse, it vanishes too.

I've tested this on Edge and Safari on Mac.

shreevatsa commented 2 years ago

I understand how this happens (try "Parsed View: Side by side" to avoid it), but it is a funny bug :-) Seems to violate some kind of "first do no harm" principle. I can try looking into fixing this in a few days, if no one gets to it first.

akprasad commented 2 years ago

Fixing PR is out. If offline, the site will just do nothing on click rather than forcing a verse to disappear. In the future we can improve the user experience here to show the reader a notification.