Checking if legend destroy exists before clearing a chart on unmount

amcharts / amcharts3-react

Official amCharts V3 React component

Apache License 2.0

118 stars 50 forks source link

Checking if legend destroy exists before clearing a chart on unmount #78

Open shivangkumar opened 6 years ago

shivangkumar commented 6 years ago

When component unmounts before chart is completely rendered, in some race scenarios the legend object does not contain the destroy method and thus fails. This commit helps prevent the unmounting from breaking.

Pauan commented 6 years ago

@shivangkumar Thanks a lot for that!

However, I don't think it's quite correct. Charts aren't required to have a legend, and if they don't have a legend then your code will cause them to never be cleaned up, ever.

I'll need to discuss this with the team to figure out the best way to fix this.