amcharts / amcharts5

The newest, fastest, and most advanced amCharts charting library for JavaScript and TypeScript apps.
Other
353 stars 95 forks source link

Data Save Control Issue #1233

Closed workingbuddy10 closed 11 months ago

workingbuddy10 commented 11 months ago

I wanted to integrate the Data Save control feature in my app but there is an issue while restoring the drawings/indicators.

Though properties are getting saved in the local storage but when I re-open the app tab after closing it, I am not getting the option of restoring the drawings/indicators.

Image 1: image

Image 2 ( rectangle series is there & saved in local storage) : image

Image 3 (After re-opening the app tab again, I am not getting the option) : image

And even though there are Two drawings in the local storage but when I re-stored it. It displayed only the last one.

image

workingbuddy10 commented 11 months ago

So the main issue is when I re-open the tab I am unable to re-store the drawings/indicators even though details/data is stored in the local storage. image

workingbuddy10 commented 11 months ago

Lastly you can see in the images, the pop-up of opening data save control is opening below the indicator control. image

martynasma commented 11 months ago

Does this happen in all amCharts demos, or just locally?

I just tried the workflow you described here: https://codepen.io/team/amcharts/pen/BaMXwQZ/f0883e6dd0d9cb1f1e56aba39443e0d7

Works fine.

Finally, which browser are you testing with?

workingbuddy10 commented 11 months ago

I am using Chrome browser.

So the main use of storing the data of the drawing/indicators is that we can retrieve the data again after re-opening the tab or re-loading the tab. But it is not happening.

View this video : https://www.loom.com/share/48f6d4577d5b43a2b76ab6a2cfb2d7bf?sid=558774fb-ac8b-4532-a7f5-7ba002cbd2d6

@martynasma

martynasma commented 11 months ago

Thanks!

This issue was fixed in dev version, and will be released soon.

We'll notify you here when that happens.

workingbuddy10 commented 11 months ago

Sure no issues!

Secondly there is should be mapping with the product name too!

Let's say, in my app I have given the option of multiple layout. A user open the chart of Google in 1D format in 1x1 layout ( single chart) , and then switches to 1x2 layout ( 2charts) and again plots the same chart ( i.e. Google in 1D format) so he should be able to retrieve/restore the drawings which was was made in 1st chart.

In the below image, I have plotted Index_SNP in 1D format and then I switch to 1x2 format and again I plotted the same chart. Now I am unable to access the drawings which I made in first chart, even though the product is same.

image

I hope it makes sense, When the product is same then user should be able to access the drawing/indicator data in multi-chart layout too. @martynasma

martynasma commented 11 months ago

Secondly there is should be mapping with the product name too!

There is: https://www.amcharts.com/docs/v5/charts/stock/toolbar/data-save-control/#Storage_scope

workingbuddy10 commented 11 months ago

Nice it worked! Thank you for your assistance.

Thanks!

This issue was fixed in dev version, and will be released soon.

We'll notify you here when that happens.

Will be waiting for this!! @martynasma

martynasma commented 11 months ago

Fixed in 5.7.1.

[5.7.1] - 2023-12-18

Fixed

Full change log.

Download options.

Make sure you clear your browser cache after upgrading. And feel free to contact us again if you are still experiencing this issue.