search

ameerthehacker / blazepack

⚡ Blazing fast dev server powered by sandpack
GNU Lesser General Public License v3.0
234 stars 17 forks source link

fix: exception on reading folder #16

Closed pjm4 closed 3 years ago

pjm4 commented 3 years ago

I noticed that when a new folder is created that an exception is thrown in the console.

e.g.  (node:41829) UnhandledPromiseRejectionWarning: Error: EISDIR: illegal operation on a directory, read
    at Object.readSync (fs.js:568:3)
    at tryReadSync (fs.js:353:20)
    at Object.readFileSync (fs.js:390:19)
    at FSWatcher.<anonymous> (/Users/<username>/.nvm/versions/node/v12.20.1/lib/node_modules/blazepack/src/commands/start-dev-server/index.js:204:28)

This addition fixes the issue.

PS My VS Code 'Code Spell Checker' extension noticed a few typos which I've corrected :)

ameerthehacker commented 3 years ago

awesome thanks for the contribution @philipjmurphy

ameerthehacker commented 3 years ago

@philipjmurphy your fix has been released in v0.0.18 please check and let me know

pjm4 commented 3 years ago

Looks good - nice one.

ameerthehacker commented 3 years ago

@all-contributors please add @philipjmurphy for bug

allcontributors[bot] commented 3 years ago

@ameerthehacker

I've put up a pull request to add @philipjmurphy! :tada: