search

ament / ament_lint

Apache License 2.0
38 stars 107 forks source link

Fix compatibility with flake8 version 5 #410

Closed roehling closed 1 year ago

roehling commented 2 years ago

The ConfigFileFinder class no longer exists in flake8 version 5. The get_style_guide() code has been updated from the latest api.legacy.get_style_guide() in flake8.

mikepurvis commented 1 year ago

This patch fixes the issues for us on flake8 5.0.4 from nixpkgs. 👍

clalancette commented 1 year ago

CI:

clalancette commented 1 year ago

New CI after fixing flake8 warnings:

clalancette commented 1 year ago

The aarch64 warning is a known flake, so this looks good. I'll go ahead and merge it.

clalancette commented 11 months ago

@Mergifyio backport iron

mergify[bot] commented 11 months ago

backport iron

✅ Backports have been created

* [#465 Fix compatibility with flake8 version 5 (backport #410)](https://github.com/ament/ament_lint/pull/465) has been created for branch `iron`