search

ament / ament_lint

Apache License 2.0
38 stars 107 forks source link

BSD 3 license (and maybe others) require a copyright notice at the top of the license file #483

Open evan-flynn-apexai opened 8 months ago

evan-flynn-apexai commented 8 months ago

While looking at the typical BSD-3 clause license, you can see the copyright line at the top that is expected to be filled in.

Later on in the first clause of the license, it mentions this copyright notice.

ament_copyright today doesn't require a BSD-3 License file to have a copyright notice at the top, but I think it should.

clalancette commented 7 months ago

This one seems really tricky.

Reading the license file, I agree with you that it seems to want to have a Copyright holder at the top, and that the rest of the LICENSE sort of expects that.

But it is unclear what we would put as the copyright holder in the package- or repository-level LICENSE file. Many packages have multiple copyright holders (in different files), so would we put all of them? Some of them? Open Source Robotics Foundation?

I don't think we can make a change here without having some kind of agreement from OSRF on what we would put here. @gbiggs pinging you to add this to the list for the new OSRA/TGC to take a look at and make a call for.

evan-flynn-apexai commented 7 months ago

@clalancette I only looked at BSD-3 btw...there might be other licenses that expect something similar or a Copyright line to be filled in. Might be something else to take a look at related to this issue. If needed I can do a quick run through of the supported licenses here to see if there are any more.