Retrofit a new version of cpplint. Ignore Qt generated moc_ files.

ament / ament_lint

Apache License 2.0

38 stars 107 forks source link

Closed rodericktaylor closed 1 month ago

rodericktaylor commented 2 months ago

Addresses. #500

fujitatomoya commented 1 month ago

@rodericktaylor thanks for the PR.

Can we divide this PR into 2 parts?

Ignore checking moc generated cpp file by ament_clang_tidy package.
Retrofit a new version of cpplint in ament_cpplist package. (against original issue https://github.com/ament/ament_lint/issues/500) especially this one, we need to see what happens to all downstream packages with new version by running CI before merging it.

rodericktaylor commented 1 month ago

Yep. Will do. I'll close this PR and create another.