search

ament / ament_lint

Apache License 2.0
38 stars 107 forks source link

Add ament_xmllint testing for all packages that we can. #508

Closed clalancette closed 4 weeks ago

clalancette commented 4 weeks ago

This is to catch invalid changes to the package.xml mostly. Note that there are a few packages in here which we cannot add this, since it would end up in a circular dependency between ament_xmllint and those packages.

This is part of getting to https://github.com/ros2/ros2cli/issues/944 , in the sense that it fixes the core to actually do this. @sloretz FYI

clalancette commented 4 weeks ago

Pulls: https://github.com/ament/ament_lint/pull/508 Gist: https://gist.githubusercontent.com/clalancette/218f908b3edab3aa90fc9fd25ab0cba7/raw/3142f13daa4b9cd4d836eb42629926ae22b23ad8/ros2.repos BUILD args: --packages-above-and-dependencies ament_clang_format ament_clang_tidy ament_cppcheck ament_cpplint ament_lint_cmake ament_mypy ament_pclint ament_pycodestyle ament_pyflakes ament_uncrustify ament_xmllint TEST args: --packages-above ament_clang_format ament_clang_tidy ament_cppcheck ament_cpplint ament_lint_cmake ament_mypy ament_pclint ament_pycodestyle ament_pyflakes ament_uncrustify ament_xmllint ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14773