american-art / npg

National Portrait Gallery
Creative Commons Zero v1.0 Universal
1 stars 6 forks source link

Problem with NPG data in the Browse App #76

Closed si-npg closed 6 years ago

si-npg commented 7 years ago

NPG objects with IDs 100697 and 100698 are coming up with no data in the Browse App (and unfortunately they come up first, since there is no title.)

si-npg commented 7 years ago

P.S. I'm guessing Classification is the problem, and I can explain the issue if it would help.

workergnome commented 7 years ago

It would be helpful to understand this issue.

si-npg commented 7 years ago

I did some work on NPG's object classifications last fall, and the updated classification for these two objects is one that I had to add to our classifications authority, as it wasn't yet included. Previously the classification for these objects was "Other". The new classification "Periodical" (and a few other new ones that I also added) was not included in the spreadsheet I had submitted earlier to Kate that linked our classifications to AAT terms. Could this unrecognized classification cause the records to get broken in the browse app? This problem would affect over 70 additional object records in our data set. Should I submit a new classifications spreadsheet? Is that being used for the browse app?

workergnome commented 7 years ago

It is being used in the browse app, through the ISI mapping. You'd have to check with @caknoblock how they'd want a new one submitted, thought

caknoblock commented 7 years ago

Please submit a revised spreadsheet with the complete set of classifications.

On Aug 7, 2017, at 8:30 PM, David Newbury notifications@github.com wrote:

It is being used in the browse app, through the ISI mapping. You'd have to check with @caknoblock https://github.com/caknoblock how they'd want a new one submitted, thought

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/american-art/npg/issues/76#issuecomment-320840300, or mute the thread https://github.com/notifications/unsubscribe-auth/ABB-qfYQmnvnxYackWDlTzNjewy1X22pks5sV9Y4gaJpZM4N7SSp.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/american-art/npg","title":"american-art/npg","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/american-art/npg"}},"updates":{"snippets":[{"icon":"PERSON","message":"@workergnome in #76: It is being used in the browse app, through the ISI mapping. You'd have to check with @caknoblock how they'd want a new one submitted, thought"}],"action":{"name":"View Issue","url":"https://github.com/american-art/npg/issues/76#issuecomment-320840300"}}}

si-npg commented 7 years ago

Classifications_Updated2017Apr.xlsx

kateblanch commented 6 years ago

This remains unresolved - objects still skeletal. http://data.americanartcollaborative.org/page/npg/object/100697 Can @caknoblock or @bsnikhila let us know if this data has been refreshed?