americanexpress / fetchye

✨ If you know how to use Fetch, you know how to use Fetchye [fetch-yae]. Simple React Hooks, Centralized Cache, Infinitely Extensible.
Apache License 2.0
42 stars 21 forks source link

chore(deps): fix peer dep issue on create-shared-react-context #79

Closed smackfu closed 1 year ago

smackfu commented 1 year ago

Description

Fixes #78

Motivation and Context

yarn install prints an error about incorrect peer deps.

warning "workspace-aggregator > fetchye-core > create-shared-react-context@1.0.3" has incorrect peer dependency "react@^16.3.0".

create-shared-react-context@1.0.5 expands the peer dependency range to include react 17 & 18 and fixes the issue.

⚠️ I did not just bump the package.json version to avoid any possible consumer impacts. Maybe that would be a better fix?

How Has This Been Tested?

Ran yarn install and verified error was gone.

Types of Changes

Checklist:

What is the Impact to Developers Using Fetchye?

No impact to developers since the yarn.lock is not used by consumers.

codesandbox-ci[bot] commented 1 year ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 809a69ef3322be340fafa618787096f8b2817feb:

Sandbox Source
quick-install Configuration
fetchye-provider-install Configuration
fetchye-redux-provider-install Configuration