search

aminblm / linkedin-application-bot

A python bot to apply all Linkedin Easy Apply jobs based on your preferences.
https://www.linkedin.com/pulse/open-source-project-1-linkedin-application-bot-your-amin-sa8af/
Other
139 stars 58 forks source link

Update linkedin.py #35

Open omarDans opened 2 months ago

omarDans commented 2 months ago

I updated the init method of the Linkeding class

First of all, in the line 19 was an error because you forgot '()' so the comparison wasnt working at all: if (platform.system == "Linux"):

Also, following the flow of the program, i think the previous check doesnt make anysense at all so i moved it to the else statement from the if at line 17: if (len(linkedinEmail)>0):

Now if the user provided the gmail and password is going to try to authenticate that way, if the user didnt provide the credentials, it's going to correctly check if the script's is being executed from linux and then if the 'firefoxProfileRootDir' variable is defined, if it is not, it will through error and exit.

aminblm commented 2 months ago

Thank you @omarDans for your PR, I will review it and merge if all goes well.

Surely I left some unchecked errors for now but I will resume work on this sooner than later.