search

amirchev / OBS-Lyrics

Manage and display lyrics to any text source in your OBS scene.
Apache License 2.0
27 stars 17 forks source link

Lyrics 2.0.0 does not show/hide on program window #38

Open iraytrace opened 2 years ago

iraytrace commented 2 years ago

In version 1.5.1 when clicking "Show Hide" the lyrics would be toggled in both preview and program windows. In 2.0.0 clicking show/hid only modifies the preview.

WaveSimm commented 2 years ago

I have the same issue as well. Have three computers and only one of them works accordingly. Others don't work expectedly. The symptom is same as Iraytrace mentioned. I can see the red backgrand color on the preview however, the sources are still displayed on the main screen.

Best regards,

GeNTooGeek commented 2 years ago

This is likely due to the use of obs.obs_frontend_get_current_preview_scene at line 1180 of lyrics+.lua. When I saw this, while looking through code for unrelated reasons, I figured that the use of this call instead of obs.obs_frontend_get_current_scene is likely due to the work for "Transition Preview to Program on lyric change" option. I haven't had time to compare the 1.5.1 code to current, but just giving an idea.

iesv commented 1 year ago

I have the same issue as well.

jbrown123 commented 1 year ago

I have the same source (pasted via paste reference) in two scenes (because I have two cameras). The hotkey only turns on/off the preview version as other's have indicated, not the program version. And ONLY if the preview scene contains the lyrics source. Seems like it should turn on/off ALL INSTANCES at the same time regardless of what is in preview or program.

[revised] The following steps require you to press the show/hide key twice to get the source to toggle as expected.

  1. Select a scene with the lyrics source
  2. Press the show/hide hotkey to confirm it is working as espected
  3. Select a scene WITHOUT the lyrics source
  4. Press the hotkey ONCE (this should toggle the source but does not)
  5. Return to the scene you selected in step 1
  6. Press the hotkey (nothing happens)
  7. Press the hotkey a second time to get it to toggle as expected
jbrown123 commented 1 year ago

WORK AROUND THAT SOLVES THIS PROBLEM!

If you create a group to hold the text box (GDI) that lyrics is using, then put that group in every scene, they will all be disabled / enabled (even in program) when you disable any of them.

See this discussion thread for further info: https://obsproject.com/forum/threads/how-enable-disable-a-source-on-all-scene.141145/ image