Open marktwilliams opened 8 years ago
Sure sounds good.
If you can send a PR request, I will definitely take a look.
I'm new to github, but it look like there is a permission issue.
When I tried a pull request, I get this message "You may not have permission to access vertica-hyperloglog. Check Preferences to make sure you’re still logged in."
I'm logged in, i checked.
On Sat, Sep 24, 2016 at 3:39 PM, amirtuval notifications@github.com wrote:
Sure sounds good.
If you can send a PR request, I will definitely take a look.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/amirtuval/vertica-hyperloglog/issues/2#issuecomment-249383423, or mute the thread https://github.com/notifications/unsubscribe-auth/AVMHF05qBT7S2jmNZ-T2oxcPeCD0goQTks5qtXxigaJpZM4KFT82 .
Regards,
Mark
To make a pull request, you need to fork the repo into your own account.
Make all the changes there, where you can push and pull.
When you are ready, you can make a pull request from your github repo to mine.
For more info see Github documentation.
Thanks, I'll work on that. I don't see an open source license attached to these projects. Are you willing to attach one of the open source licenses?
BTW, my name is Mark.
On Mon, Sep 26, 2016 at 10:12 AM, amirtuval notifications@github.com wrote:
To make a pull request, you need to fork the repo into your own account.
Make all the changes there, where you can push and pull.
When you are ready, you can make a pull request from your github repo to mine.
For more info see Github documentation.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/amirtuval/vertica-hyperloglog/issues/2#issuecomment-249580908, or mute the thread https://github.com/notifications/unsubscribe-auth/AVMHF6J6P3mZoKhS6JRjYsLZoR35xMSsks5qt9LcgaJpZM4KFT82 .
Regards,
Mark
Added a license - Apache license 2.0.
Thanks :-)
When importing HLL data to vertica the only real choice is to use HEX. Vertica can only import hex_to_binary into a binary column. I've overloaded HLL_MERGE_COMPUTE to use varbinary as an input type. Would you like be to add it to the project?