search

amitaibu / og

A fork to work on OG8
https://github.com/Gizra/og
29 stars 16 forks source link

WIP: Adding sniffer env on travis. #263

Closed ordavidil closed 8 years ago

ordavidil commented 8 years ago

262

pfrenssen commented 8 years ago

I think actually that Travis is not the right tool for the job here, look at the complexity of the code that is being added here.

Why don't we use Scrutinizer instead? It is specifically designed for this task, it is very simple to set up: we only need to add Coder as a dev-dependency to composer.json and provide a phpcs.xml.dist file. And as a bonus the coding standards test will run in parallel to the Travis tests. It will be clear at a glance if it are the tests that fail or the coding standards.

Ref https://scrutinizer-ci.com/docs/tools/php/code-sniffer/

amitaibu commented 8 years ago

Why don't we use Scrutinizer instead?

No reason. We can use it. I don't have much experience with it, though.

pfrenssen commented 8 years ago

I will be attending Drupalaton next week, and am looking forward to 4 days of sprinting. If you want I can set up a trial then?

amitaibu commented 8 years ago

Sounds good.

On Aug 4, 2016 7:08 AM, "Pieter Frenssen" notifications@github.com wrote:

I will be attending Drupalaton next week, and am looking forward to 4 days of sprinting. If you want I can set up a trial then?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/amitaibu/og/pull/263#issuecomment-237447361, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHrC5eNW6LTdwMwSM32VOF4BegYEwvvks5qcWWqgaJpZM4JTq2n .

amitaibu commented 8 years ago

Closed in favor of #301