search

amitmodak89 / magento-w2p

Automatically exported from code.google.com/p/magento-w2p
0 stars 0 forks source link

Safely delete attachments #455

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Add functionality for safe file deletion.
Make sure that deleting attachment does not break any quotes (probably will 
need to delete them too) or orders.
Make this in Attachments model, so that the functionality is reusable.

Original issue reported on code.google.com by jamb...@gmail.com on 8 Feb 2011 at 12:44

GoogleCodeExporter commented 8 years ago 
Attachments can now be deleted safely from the system. If they are part of any 
order, the order will be updated to reflect the deletion by not showing deleted 
file in file list.
It should be noted however that no recalculation of the order is made so if 
invoicing is done after some files are deleted this will not change any of the 
amounts.

changes in revision r1399

This issue needs time added to it.

Original comment by jamb...@gmail.com on 22 Feb 2011 at 7:31

GoogleCodeExporter commented 8 years ago 
I thought we only delete the file and leave the record in the order.
There will be no way of restoring the file by other means if there is no record 
of it.
The user would just get 404 if the file link was clicked.

Original comment by zetapri...@gmail.com on 23 Feb 2011 at 12:39

GoogleCodeExporter commented 8 years ago 
When file is deleted from order you get a comment with file name added to the 
order like:
Files deleted: image01.jpg

If you want to revert to just leaving the files it is fine by me.

Original comment by jamb...@gmail.com on 23 Feb 2011 at 7:54

GoogleCodeExporter commented 8 years ago 
ah, ok
this should have been part of the task description 

we really need to start using UML

Original comment by zetapri...@gmail.com on 23 Feb 2011 at 8:19

GoogleCodeExporter commented 8 years ago 
Test if deleting file that is part of an order affects order display in admin 
and frontend.
In both places, deleted file should not be shown as part of the order.
In admin a comment should be shown with names of files that are deleted.

Original comment by jamb...@gmail.com on 7 Mar 2011 at 1:13

GoogleCodeExporter commented 8 years ago 
This does not work for files with identical file names. Ex: I upload 1 file 
twice and 2 more different files. Then go to Attach.Mng. to delete one of the 
duplicate files and one of the different ones. The duplicate file deletion is 
not processed in the frontend, order admin details or order comments. Only 
files without identical file names are removed from the order. 
In other words, if I delete a file from the admin that has a duplicate in the 
same order, the deletion will not be registered in frontend or backend order 
details.

Original comment by agur...@gmail.com on 7 Mar 2011 at 2:32

GoogleCodeExporter commented 8 years ago 
This should work now. r1429

Original comment by jamb...@gmail.com on 7 Mar 2011 at 4:24

GoogleCodeExporter commented 8 years ago

Original comment by jamb...@gmail.com on 7 Mar 2011 at 4:24

GoogleCodeExporter commented 8 years ago 
Yep, works fine now.

Original comment by agur...@gmail.com on 7 Mar 2011 at 8:43

GoogleCodeExporter commented 8 years ago

Original comment by zetapri...@gmail.com on 7 Mar 2011 at 9:26