Closed GoogleCodeExporter closed 8 years ago
Let's start with a prototype. The map and KML should be visible to users in
order details as well.
Original comment by zetapri...@gmail.com
on 16 Mar 2011 at 10:42
User experience is in another issue. Here we stick to admin experience.
I could use some mock ups of how to display things, like map size, text box for
KML or link to it. Things like that.
I think that out side of product page, maps should be static, without option
for admin or user to mess with them after placing the order.
Original comment by jamb...@gmail.com
on 17 Mar 2011 at 9:54
We need more units here.
To present this as custom option I have to override classes that conflict with
file uploader. Overall custom options prove very hard to extend.
They are all hard coded in core files, with no real extension points.
If we are to go on with custom options path I suggest we make a general options
extension that overrides magento's, and is more flexible for extending.
With file uploader I cheated by using existing file option and adding a flag to
distinguish between core file option and ours. Even like this I had to override
some core files.
With this, there is nothing to base it on and I have to override even more
files. Not very future proof strategy.
Original comment by jamb...@gmail.com
on 17 Mar 2011 at 2:03
Doesn't sound right to me either.
We don't really need much from the server side here - just show us that IFRAME
with a certain SRC. Right?
Maybe abandon a new product option approach altogether and look for an
alternative solution?
I guess it will require theme mods, which is far from ideal too.
Maybe cheat again and use a standard control with some sort of a hint for JS to
be replaced with a map? Say a text area control. In the end the text area will
hold the KML, but the user will see a map.
Original comment by zetapri...@gmail.com
on 17 Mar 2011 at 10:02
Well you're kind of late with that response. I spend entire day yesterday to
make it work as a custom option.
Original comment by jamb...@gmail.com
on 18 Mar 2011 at 8:46
Original comment by zetapri...@gmail.com
on 24 Mar 2011 at 9:27
Hide and hardcode the 3 options we have in admin right now.
Add 2 new options:
* Product page map size width
* Product page map size height
* Order page map size width
* Order page map size height
Can you do them as width: [ ] height [ ] in one row, but separate inputs?
THINGS TO TRY
Try if this GPS sensor setting can be safely set to YES on desktops. I don't
see any harm and would rather have it on.
Try https maps on an https mage page and see if you get a warning from the
browser.
Original comment by zetapri...@gmail.com
on 24 Mar 2011 at 11:03
Do you have an HTTPS page? I don't and simply putting https won't work.
Original comment by jamb...@gmail.com
on 24 Mar 2011 at 11:47
Add shopping cart map size settings to the admin as well.
Original comment by zetapri...@gmail.com
on 28 Mar 2011 at 11:28
Added all map size settings - product page, admin page and
cart/checkout/customer order details pages.
File responsible:
http://code.google.com/p/magento-w2p/source/browse/branches/ZetaPrints_Distribut
ionMap/app/code/community/ZetaPrints/DistributionMap/etc/system.xml?spec=svn1490
&r=1490
Replaced admin static map with dynamic one.
Original comment by jamb...@gmail.com
on 30 Mar 2011 at 1:56
Do need a Wiki for this.
Don't even know where the settings should be in admin. All I see on product
details page is a field that seems to be the map under "Custom options".
Original comment by agur...@gmail.com
on 30 Mar 2011 at 5:36
Is this reading helpful? DistributionMap
It probably needs polishing.
Original comment by jamb...@gmail.com
on 30 Mar 2011 at 5:48
There seems to be a conflict with Dynamic File Attachments extension. Can't set
the custom option to "File". It automatically changes to "Upload files vie
AJAX" on save.
http://ec2-174-129-95-130.compute-1.amazonaws.com/mageimage/index.php/magentot-0
2/text-img-01.html
Tried it on /mageimage/
web_to_print_store_incl_theme 1.8.4.0beta5 (beta)
ZetaPrints_DistributionMap 0.1.5b (beta)
ZetaPrints_Attachments 1.0.4b (beta)
Original comment by agur...@gmail.com
on 31 Mar 2011 at 8:07
whoooops, it should be field not file. My typo.
Original comment by jamb...@gmail.com
on 31 Mar 2011 at 9:33
Fixed now
Original comment by jamb...@gmail.com
on 31 Mar 2011 at 9:33
Tried it on /mageimage/
ZetaPrints_DistributionMap 0.1.5b (beta)
Where is that alleged link to the KML file? I don't see one as a customer nor
admin.
Original comment by agur...@gmail.com
on 31 Mar 2011 at 2:16
Just under maps.
It needed little adjustments because of changes I made for 1.4.2 v. of Magento
Original comment by jamb...@gmail.com
on 31 Mar 2011 at 3:13
Can you post a diff for those adjustments, please?
Original comment by agur...@gmail.com
on 31 Mar 2011 at 3:33
For 1.4.2? r1499
Original comment by jamb...@gmail.com
on 31 Mar 2011 at 4:11
Can you change the text to "Download KML file" instead of "Option KML file" ?
Original comment by agur...@gmail.com
on 31 Mar 2011 at 5:28
done in r1505
Original comment by jamb...@gmail.com
on 31 Mar 2011 at 6:01
http://code.google.com/p/magento-w2p/source/diff?spec=svn1504&r=1504&format=side
&path=/branches/ZetaPrints_DistributionMap/js/custom/distromap.js - line 139
Fixing KML link not displaying.
Original comment by jamb...@gmail.com
on 31 Mar 2011 at 6:09
Why don't we hide the text field in the front end?
At the moment if the map is configured to be narrower than the text field the
field sticks out on both sides.
Original comment by zetapri...@gmail.com
on 1 Apr 2011 at 4:06
Because if an input is hidden with display: none it is not submitted with the
form.
And IE does not allow to change input type to hidden for example (its older
versions)
Original comment by jamb...@gmail.com
on 1 Apr 2011 at 7:37
Set input visibility to hidden.
r1507
Test if it is hidden and if rest of process works as before
Original comment by jamb...@gmail.com
on 1 Apr 2011 at 12:54
Tested on /mageimage/
http://ec2-174-129-95-130.compute-1.amazonaws.com/mageimage/index.php/magentot-0
2/text-img-01.html
Procedure works fine in all browsers but for some reason I can't finalize the
order and get stuck on "Payment information" step of the checkout. Did you
change smth? Don't seem like it can be related to this issue.
Original comment by agur...@gmail.com
on 1 Apr 2011 at 4:15
This has no relation to order process. But it may be JS error. Will take a look.
Original comment by jamb...@gmail.com
on 4 Apr 2011 at 11:29
I thin problem from comment 26 is what is described in #511, so I guess further
discussion should go there.
Original comment by jamb...@gmail.com
on 4 Apr 2011 at 12:39
Tested on /mageimage/
ZetaPrints_DistributionMap 0.1.8b (beta)
Original comment by agur...@gmail.com
on 4 Apr 2011 at 5:47
Original comment by jamb...@gmail.com
on 7 Apr 2011 at 3:26
Original comment by ad...@zetaprints.com
on 8 Apr 2011 at 9:02
Login to admin, go to System > Cofiguration > Google API > Google maps settings
and fill in corresponding fields as desired.
Field names are self explanatory.
Original comment by jamb...@gmail.com
on 8 Apr 2011 at 9:42
This is included in the help post:
http://www.zetaprints.com/magentohelp/distribution-map-extension/
Note. Post is still private. Needs to be published along with:
http://www.zetaprints.com/magento-web-to-print/distribution-map
and after issues 394 and 395 on redmine are resolved
Original comment by agur...@gmail.com
on 8 Apr 2011 at 4:42
Original comment by ad...@zetaprints.com
on 20 Apr 2011 at 6:26
Original issue reported on code.google.com by
jamb...@gmail.com
on 16 Mar 2011 at 7:24