Fix MySQL case-insensitive search, order by id when looking for next short code

amitt001 / pygmy

An open-source, feature rich & extensible url-shortener + analytics written in Python :cookie:

https://demo.pygy.co/pygmy

MIT License

695 stars 134 forks source link

Fix MySQL case-insensitive search, order by id when looking for next short code #17

Closed Hu1-Li closed 6 years ago

Hu1-Li commented 6 years ago

fix bug when getting latest short code using order by link.id
fix bug when comparing two short code using collate

coveralls commented 6 years ago

Coverage increased (+0.1%) to 53.917% when pulling 7185d7c065e45e99693956466a328cb17ec40cc6 on Hu1-Li:issue15 into 863fc7a51da80ca6e8c0cc26a4e429cbdb5e9218 on amitt001:master.

Hu1-Li commented 6 years ago

This is my first time working with CI, I think i can do better next time, sorry for the inconvenient.

As for merging these commits into one commit, you can select squash and merge in here

amitt001 commented 6 years ago

Fixes #15

Squashed your commits and fixed with commit https://github.com/amitt001/pygmy/commit/67260baca6b3ecf11848169f20a857e8fd384762

@Hu1-Li your initial event.listen way of altering in case of MySQL was better as checking config.database['engine'] == 'mysql' in Link class made it unusable for directly importing and using it. It became dependent on config. Sorry for all the rework.

Thanks for fixing this.