Added full country name to short link stats

amitt001 / pygmy

An open-source, feature rich & extensible url-shortener + analytics written in Python :cookie:

https://demo.pygy.co/pygmy

MIT License

695 stars 134 forks source link

Added full country name to short link stats #36

Closed hamidaskarov closed 5 years ago

hamidaskarov commented 5 years ago

As you say in https://github.com/amitt001/pygmy/issues/34, i added a dict that contain full names of countries and changed template and view, so it shows full name of country with the code of country.

coveralls commented 5 years ago

Coverage remained the same at 68.09% when pulling 3b0fe83b4e9c466dcc2342f63ec805581505d0b1 on whoami38:add-country-full-name into 91572f9f8497c37fc44e41437cec124de875e240 on amitt001:master.

amitt001 commented 5 years ago

@whoami38 Thanks for the PR :) Can you share the source of "iso2full.py" data, please? The changes look good. I will review/merge it in the evening today.

hamidaskarov commented 5 years ago

I use following resources for the data: 1.https://github.com/pageflt/iso-country-codes/blob/master/iso_country_codes.py 2.https://stackoverflow.com/questions/12906090/country-name-from-iso-short-code-in-dictionary-how-to-deal-with-non-ascii-chars

amitt001 commented 5 years ago

@whoami38 Just tested and it looks good. I will rebase and merge it on the weekend.

It's a nice improvement in the app. Thanks for your contribution 🙂 Have a look at other issues also and see if anything interests you

amitt001 commented 5 years ago

Changes are now live on the website