search

amitt001 / pygmy

An open-source, feature rich & extensible url-shortener + analytics written in Python :cookie:
https://demo.pygy.co/pygmy
MIT License
695 stars 134 forks source link

Already shortened url message fixed #38

Closed hamidaskarov closed 5 years ago

hamidaskarov commented 5 years ago

I think it(https://github.com/amitt001/pygmy/issues/37 ) happens because of some errors return a list instead of string, so i convert this list to string if it is list.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 68.09% when pulling f58b6dedaa27dda806a603ada3eada115a0404e3 on whoami38:already_shortened_url into 91572f9f8497c37fc44e41437cec124de875e240 on amitt001:master.

hamidaskarov commented 5 years ago

Instead of joining API errors, i have changed the error_msg.py file which getting errors from API and convert dict for rendering, it now return fully lists instead of list&string mix and because of that i also changed some(400.html,404.html,500.html) templates.Instead of printing error directly i've added for loops for printing elements of list.

amitt001 commented 5 years ago

Good job! Thanks for the PR :)