search

ammarahm-ed / react-native-actions-sheet

A Cross Platform(Android, iOS & Web) ActionSheet with a flexible api, native performance and zero dependency code for react native. Create anything you want inside ActionSheet.
https://rnas.vercel.app
MIT License
1.56k stars 123 forks source link

SheetManager doesn't seem to work with New Architecture enabled. #395

Open danieljvdm opened 1 month ago

danieljvdm commented 1 month ago

I recently enabled new architecture and whenever I try to present sheets via the SheetManager, they just don't show up. I see the transparent black background appear but no sheet renders, no matter what style I give it, e.g.:

    <ActionSheet
      containerStyle={{
        backgroundColor: 'blue',
        height: 400,
        alignItems: 'center',
        justifyContent: 'center',
      }}
    >

Using ActionSheets directly within components still works.

danieljvdm commented 1 month ago

It seems that if I make isModal={false} things work again.

Medkhat commented 3 weeks ago

I encountered this issue as well. This problem didn’t exist when I used the package a year ago. I resolved it by setting isModal={false}. It seems to be related to using react-native-actions-sheet alongside react-native-reanimated. See #391 and #337

jvgeee commented 1 week ago

@ammarahm-ed please look into this when you have a chance, I had all my action sheets break on Android after upgrading to the new Expo SDK (which enables new architecture by default).

I've noticed that some of my action sheets work fine without isModal={false} (and actually break when I put that on them) - these are action sheets that are called by a parent component that is rendered with a scrollview; maybe it's something to do with reanimated acting on some of the views and not others? not sure, but happy to debug some more if you need.

frozencap commented 1 hour ago

same issue. broken on Android with New Architecture enabled.