search

ammarahm-ed / react-native-ijkvideo

A Cross Platform (Android & iOS) video & audio component with react-native-video like API & all formats support based on IJKPlayer FFMpeg 3.4
MIT License
25 stars 9 forks source link

Package name #2

Closed maximilize closed 4 years ago

maximilize commented 4 years ago

Seems like you hard forked this code from https://github.com/king6cong/react-native-ijkplayer

Maybe you also should rename the package name inside package.json. It's somehow confusing to deal with the repo name react-native-ijkvideo, but the module name react-native-ijkplayer.

maximilize commented 4 years ago

However I created the pull request #3

ammarahm-ed commented 4 years ago

Yea thanks, actually this is not yet ready to be used. Only the android side is done (almost) I still need to clean it up and complete the ios side too. And yea that needs to be done too. Thanks! When I get some time, I will cover this up ASAP.

ammarahm-ed commented 4 years ago

Okay, I have merged this, thanks for the pull request. I will fix the other stuff soon. This library is great, just incomplete at the moment