Closed Boarders closed 5 years ago
So lateโฆ.
Test out if algebraic-graphs
can be used for nice dot
output.
This is (finally) done as of this commit: https://github.com/amnh/PCG/commit/f2b789ea5f9a047e353d7ff720310044313f0e43
Note that along the way I wrote some code to be found in app/graphviz-examples
for generating nice looking network and display tree examples in dot. Should we need to produce more such diagrams this is a good place to start looking. In particular, I can imagine more of the display tree diagrams being extremely useful for when it comes to explaining anything related to that.
The tests in https://github.com/amnh/PCG/issues/105 revealed several things that we had not considered as far as testing compatibility when adding network edges.
In total if edge1 = (src1, tgt1) and edge2 = (src2, tgt2) we currently test:
we say p2 is the network pair of p1. If e1 is a network edge i.e. an edge of the form (p1, n) in the above diagram then we have to check that p2 is not ancestral to e2. Similarly if the source of e2 is a parent of a network node then we must check that the network pair of src2 is not ancestral to e1.
We should add documentation for these different cases including diagrams explaining why they are disallowed.