amnh / PCG

๐™‹๐™๐™ฎ๐™ก๐™ค๐™œ๐™š๐™ฃ๐™š๐™ฉ๐™ž๐™˜ ๐˜พ๐™ค๐™ข๐™ฅ๐™ค๐™ฃ๐™š๐™ฃ๐™ฉ ๐™‚๐™ง๐™–๐™ฅ๐™ โธบ Haskell program and libraries for general phylogenetic graph search
28 stars 1 forks source link

Add candidate network edge documentation #128

Closed Boarders closed 5 years ago

Boarders commented 5 years ago

The tests in https://github.com/amnh/PCG/issues/105 revealed several things that we had not considered as far as testing compatibility when adding network edges.

In total if edge1 = (src1, tgt1) and edge2 = (src2, tgt2) we currently test:

We should add documentation for these different cases including diagrams explaining why they are disallowed.

wardwheeler commented 5 years ago

So lateโ€ฆ.

recursion-ninja commented 5 years ago

Test out if algebraic-graphs can be used for nice dot output.

Boarders commented 5 years ago

This is (finally) done as of this commit: https://github.com/amnh/PCG/commit/f2b789ea5f9a047e353d7ff720310044313f0e43

Note that along the way I wrote some code to be found in app/graphviz-examples for generating nice looking network and display tree examples in dot. Should we need to produce more such diagrams this is a good place to start looking. In particular, I can imagine more of the display tree diagrams being extremely useful for when it comes to explaining anything related to that.