amondnet / vercel-action

This action make a deployment with github actions instead of Vercel builder.
https://vercel.com/docs/cli
MIT License
635 stars 98 forks source link

Failing tests #219

Closed glitteringkatie closed 1 year ago

glitteringkatie commented 1 year ago

Hi! I've forked with a few changes specific to my team. I'm trying to pull in recent changes to keep us in parity, however running npm run all isn't completing. First off there are a few lint errors that are easy to get over ('retry' is already declared in the upper scope on line 41 column 10 and Return values from promise executor functions cannot be read). Once those lint errors are fixed, it's the tests that die.

 FAIL  ./index.test.js
  ● Test suite failed to run

    Your test suite must contain at least one test.
 FAIL  example/angular/src/test.ts
  ● Test suite failed to run

    Jest encountered an unexpected token
...
Details:

    /Users/katiehughes/vercel-action/example/angular/src/app/app.component.spec.ts:1
    ({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,jest){import;
                                                                                      ^^^^^^

    SyntaxError: Cannot use import statement outside a module

      at Runtime.createScriptFromCode (node_modules/jest-runtime/build/index.js:1598:14)
 FAIL  example/angular/src/test.ts
  ● Test suite failed to run

    Jest encountered an unexpected token
...
 Details:

    SyntaxError: /Users/katiehughes/vercel-action/example/angular/src/test.ts: Missing semic)

       8 | } from '@angular/platform-browser-dynamic/testing';
       9 |
    > 10 | declare const require: any;
         |        ^
      11 |
      12 | // First, initialize the Angular testing environment.
      13 | getTestBed().initTestEnvironment(

Does anyone else get these test failures when running npm run all? The missing semicolon stuff feels like a misnomer. 🤔 I'm on node v16.17.0 and got the same failures when running both on the merge into my fork and also on a clean checked-out version of master in your repo.

glitteringkatie commented 1 year ago

JK it fails locally even on my forked repo before I pull in any of the latest changes. I'm going to assume this is a me thing unless anyone from the vercel-action team wants to re-open this