search

amosproj / amos2021ss02-project2-context-map

A context map for corporate data
MIT License
1 stars 0 forks source link

Chord details with search #374

Closed joluj closed 3 years ago

joluj commented 3 years ago

Implements search mapping (#234) in chord details (#344)

joluj commented 3 years ago

Looks good, but I don't like that the entity types are just text fields. Since they are clickable they should be some kind of button or pressable text: image

Thats not part of this PR. Furthermore I think it's also very very hard to edit those since there is not easy option to change it. We must fork the original framework if we want to make them as buttons.

PianoRollRepresentation commented 3 years ago

I opened an issue for that (#377). It can be implemented in another PR.