amowry / WARBL2

WARBL2 Code and design files
https://warbl.xyz/index.html
GNU General Public License v3.0
11 stars 3 forks source link

Current transient filter causes a spurious note with uilleann fingering #23

Closed amowry closed 4 months ago

amowry commented 4 months ago

Will uilleann pipes fingering, the transient filter in 4.1 cause an extra low D note to be played when all holes (including bell sensor) are covered and then one finger is lifted. The low D is played briefly during the transient filter delay, and then the desired note is played.

Edit: It happens with the new transient filter too and actually happens with any fingering chart. When all holes and the bell sensor are covered (which silences the WARBL with any fingering chart), and then any finger is removed, the lowest note on the scale plays during the filter delay period before the correct note plays.

amowry commented 4 months ago

I pushed a fix for this to the develop branch.