[documentation] Bad references to \Amp\Promise in documenttion

[gauthier-scano]

Hello,

Maybe I'm wrong but I would like to advise you that the document at https://amphp.org/amp still have references to \Amp\Promise for awaitAll, awaitFirst and awaitAny.

Shouldn't it be "Amp\Future" instead of "Amp\Promise" for these 3 functions ?

Regards

[kelunik]

You're completely right. Mind sending a pull request to amphp/amp's README?

[gauthier-scano]

Done ! Here is the related link of the pull request : https://github.com/amphp/amphp.org/pull/8

[kelunik]

Thank you! The docs in this repo / the website should automatically update soon. 🙂

[gauthier-scano]

Nice ! Thank you for your feedback.

[gauthier-scano]

Reopening because it looks like website did not auto-update.

(I checked and it's not a local browser cache issue)

[kelunik]

Sorry, this was an oversight. https://github.com/amphp/amphp.org/pull/8/files is a PR in this repository, but it should have been to the README at https://github.com/amphp/amp/blob/3.x/README.md

The automatic sync reverted your change: https://github.com/amphp/amphp.org/commit/bf52ec2ba927f072ee4bc72b35724ed232ff1427

[gauthier-scano]

Oh ok, do I have anything to do ?

[kelunik]

It'd be wonderful if you could reopen the PR against https://github.com/amphp/amp/blob/3.x/README.md, yes.

[gauthier-scano]

Didn't have the right to reopen, I have created a new one.

[kelunik]

You opened it in the wrong repository. You need to edit the readme in amphp/amp, not this repository.

[gauthier-scano]

My bad, it's done.

[kelunik]

I don't see a new PR, what am I missing?

[kelunik]

It's here now, thanks!