search

amphp / ext-uv

Other
191 stars 28 forks source link

Fixes bwoebi/php-uv#85 (arginfo) #90

Closed cdosoftei closed 4 years ago

cdosoftei commented 4 years ago

Addresses the warnings referred by the aforementioned issue.

While looking around for best practice, I'm still not convinced on what's the right approach to referencing the "void" arginfo structure, i.e. one struct for all argument-less functions vs. one "void" struct for each function. I went with the former for simplicity and binary output optimization, but I am happy to address the PR if needed, thanks!

bwoebi commented 4 years ago

A single arginfo for them all is perfectly fine, everything else is just making it spammier :-)