amplab / snap

Scalable Nucleotide Alignment Program -- a fast and accurate read aligner for high-throughput sequencing data
https://www.microsoft.com/en-us/research/project/snap/
Apache License 2.0
288 stars 66 forks source link

Feature request - accept .fa.gz input files #132

Closed haiqu closed 2 years ago

haiqu commented 3 years ago

Seems strange to need extracted .fa files as input when reference genomes are distributed as .fa.gz files, and since the capability is already in the code this should be trivial to implement.

bolosky commented 3 years ago

Yes, we should do this.

From: Rob Judd notifications@github.com Sent: Thursday, December 17, 2020 6:17 AM To: amplab/snap snap@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [amplab/snap] Feature request - accept .fa.gz input files (#132)

Seems strange to need extracted .fa files as input when reference genomes are distributed as .fa.gz files, and since the capability is already in the code this should be trivial to implement.

- You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Famplab%2Fsnap%2Fissues%2F132&data=04%7C01%7Cbolosky%40microsoft.com%7Cf6f5a0b30ca748111fcd08d8a2967a5a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637438114470011315%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=PqJZbbu0%2Fl5VcAAjFiUvW5lH9bgPE8kJKdjzLJ9xQMY%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAHPTWIJE7TKJYVLJUQWCFLSVIHHLANCNFSM4U7XLDEQ&data=04%7C01%7Cbolosky%40microsoft.com%7Cf6f5a0b30ca748111fcd08d8a2967a5a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637438114470021311%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=6MOsygtBnuVbzsjNpb5aNYjzVs53etECc1oDXTvHTUc%3D&reserved=0.

bolosky commented 2 years ago

This is done in 2.0.1. As you might imagine, it wasn't as easy as it seemed, or we would have done it earlier.