search

amplitude / experiment-react-native-client

React Native Client SDK for Amplitude Experiment
MIT License
6 stars 2 forks source link

Request Compatible With React Native MMKV Local Storage #18

Closed adityaputra11 closed 1 year ago

adityaputra11 commented 1 year ago

currently we use amplitude experiment amplitude for our project, but we have plan to move to react native mmkv because this storage is more faster than asyncstorage, can we request to use react native mmkv as experiment local storage?

bgiori commented 1 year ago

Hi @adityaputra11, thanks for submitting this issue.

Can mmkv and async storage exist side-by-side?

The sdk latency is dominated by network, and doesn't read or write from storage too often, or with any significant volume. I can look into updating to mmkv, but this includes changing our docs, making the installation instructions version dependent, which is not ideal.

One option would be to expose the storage interface and allow the app to configure the implementation.

Let me know what you think!

adityaputra11 commented 1 year ago

Hi @bgiori i think the option to expose the storage interface is quite interesting

adityaputra11 commented 1 year ago

actually yes mmkv and async storage exist side by side, in our app, actually we though changing storage will help a lot to reduce latency

bgiori commented 1 year ago

We use an in memory object as a cache for reading variants from storage, so reads, which are by far the most frequent, should not access async storage at all. Write occur after a call to fetch(), which makes a network request, and writes a single, albeit large, value to async storage. Since the network request is ~30ms at its fastest, the single write should add negligible latency.

That said, I understand that you may want to implement your own storage for performance or to reduce bundle/app size by consolidating storage libraries.

adityaputra11 commented 1 year ago

sure, thank you for insight :)