amplitude / experiment-react-native-client

React Native Client SDK for Amplitude Experiment
MIT License
6 stars 2 forks source link

Move types to @amplitude/experiment-core #46

Open jeremyallison opened 5 months ago

jeremyallison commented 5 months ago

Hi team,

Would it be possible to merge duplicate core types such as client.d.ts, variant.d.ts, and other types from these two packages:

... into @amplitude/experiment-core ?

Typing the ExperimentClient either from the Web type OR the React Native type seems like a bit of a shame when it seems they're pretty much the same?

I'm implementing a Provider that's meant to be common, both to our React web app + and our two React Native apps, both using typescript on a monorepo. My Provider is supposed to receive an ExperimentClient, either instantiated from @amplitude/experiment-react-native-client or @amplitude/experiment-js-client 🙏