Cache only valid responses

ampproject / amp-toolbox-php

AMP Optimizer PHP library

Apache License 2.0

74 stars 23 forks source link

Cache only valid responses #531

Closed dritter closed 1 year ago

dritter commented 1 year ago

Hi!

Recently we discovered that some requests to fetch the metadata failed, but were cached regardless of the status code. This PR adds a guard, that only valid responses are cached.

This fixes #530

dritter commented 1 year ago

@schlessera Any chance to get this merged? This is quite urgent for us, because all our amp pages are invalid without this fix (see #530 ).

swissspidy commented 1 year ago

cc @westonruter