search

ampproject / amp-wp

Enable AMP on your WordPress site, the WordPress way.
https://wordpress.org/plugins/amp/
GNU General Public License v2.0
1.79k stars 384 forks source link

Lightbox settings are not honored when Gutenberg is active. #6485

Closed milindmore22 closed 3 years ago

milindmore22 commented 3 years ago

Bug Description

While debugging an issue for a user from support topic, I noticed that AMP Lightbox is forced on Images and Gallery even when the user has not opted-in for it.

The issue may be something similar to #5122

Expected Behaviour

Lightbox toggle settings should be honored images should not open in lightbox

Steps to reproduce

  1. Install and Activate the latest Gutenberg plugin
  2. Create a New post
  3. Add Image block ( do not opt-in for lightbox)
  4. Add Gallery Block (do not opt-in for lightbox )
  5. Save -> Visit Post -> AMP page
  6. Click on Image (Open up in Lightbox)
  7. Click on any image from Gallery (Opens up in Lightbox)

Screenshots

https://recordit.co/SdhDQ4ZegK

Additional context

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

westonruter commented 3 years ago

@milindmore22 Please confirm if it is the same issue via https://github.com/ampproject/amp-wp/issues/5122#issuecomment-764883002 to turn off auto-lightbox.

milindmore22 commented 3 years ago

Yes, it's the same issue, but it was reproducible with the Gutenberg plugin and not with Core Block Editor.

westonruter commented 3 years ago

I'm confused. The issue doesn't happen when Gutenberg is deactivated?

milindmore22 commented 3 years ago

I am unable to reproduce the issue today, I think it may be the cached results that got me confused, sorry to take your time I will mark this issue as closed.