Able to use CONSENT_STRING macro with amp-ad-custom

michael-stevens commented 3 years ago

Describe the new feature or change to an existing feature you'd like to see

We use the amp-ad-custom tag. We would like to be able to receive consent string data when generating the ad, in particular through use of the CONSENT_STRING macro mentioned here:

https://github.com/ampproject/amphtml/blob/master/extensions/amp-consent/customizing-extension-behaviors-on-consent.md

Describe alternatives you've considered

Considered using data-block-on-consent but this only permits simple yes/no decisions, does not allow more granular decisions as to which functionality is provided based on exact consents.

Additional context

Will become increasingly important with more and more sites implementing consent requirements.

I'm not 100% clear if this is a bug or a feature request - I couldn't see any documentation stating that what I want to do is expected to work, therefore I considered it more of a feature request.

micajuine-ho commented 3 years ago

Considered using data-block-on-consent but this only permits simple yes/no decisions, does not allow more granular decisions as to which functionality is provided based on exact consents.

See https://github.com/ampproject/amphtml/issues/31607

We would like to be able to receive consent string data when generating the ad, in particular through use of the CONSENT_STRING macro mentioned here:

As for utilizing the CONSENT_STRING macro, would this be in the request URL?

michael-stevens commented 3 years ago

See #31607

Will take a look.

As for utilizing the CONSENT_STRING macro, would this be in the request URL?

Yes, in the src attribute of amp-ad-custom (or whatever other reasonable means influences that url).

micajuine-ho commented 3 years ago

Just curious, what is your use case for using amp-ad-custom?

dianomi-mjs commented 3 years ago

Hi, amp-ad was not available to us so we were advised to use amp-ad-custom instead as per #19951

I believe CONSENT_STRING is integrated in to amp-ad so we're just looking for the same thing in amp-ad-custom. Our requirement is to not display ads if there's not appropriate consent and to customise the ads if some consent has been withdrawn.

micajuine-ho commented 3 years ago

/cc @ampproject/wg-monetization

dianomi-mjs commented 3 years ago

Hi @micajuine-ho any feedback on this? Possibly just an oversight that CONSENT_STRING is integrated in to amp-ad but not amp-ad-custom, and can easily be added?

dianomi-mjs commented 3 years ago

/cc @rudygalfi

dianomi-mjs commented 3 years ago

@zhouyx I can see you helped on a previous similar issue on amp-ad. Can you assist here?

lannka commented 3 years ago

@dianomi-mjs we are launching (in about 2 wks) a new way to serve AMPHTML ads in AMP as a replacement of the template ads solution. That means, we will soon deprecate the amp-ad-custom extension. For any new development work, I would highly recommend to switch to the new way. @calebcordry do we have any docs at this moment for the no-signing?

dianomi-mjs commented 3 years ago

Thanks - our amp-ad-custom ads have suddenly stopped working. Has this been removed or broken in a new release?

Perhaps I should raise a separate issue for this.

calebcordry commented 3 years ago

Looks like we are going to rollback to fix the template issue.

As far as the new feature: for now we only have the no signing design doc here. I will update a4a docs in the near future. The idea is that we will try to render any served creative as amphtml unless the ad server sends a header opting out or it fails our client side validation. This should be much easier for ad networks as the no longer have to worry about cryptographic signing. LMK if you have questions.

michael-stevens commented 3 years ago

I've requested access to that doc.

On Wed, 17 Mar 2021 at 16:00, Caleb Cordry @.***> wrote:

Looks like we are going to rollback to fix the template issue.

As far as the new feature: for now we only have the no signing design doc here https://docs.google.com/document/d/1hbDFBjdbVj7BXa5dUtejarCsx6zNFo877RDNqCkfQTk/edit#heading=h.e9psqju9yift. I will update a4a docs in the near future. The idea is that we will try to render any served creative as amphtml unless the ad server sends a header opting out or it fails our client side validation. This should be much easier for ad networks as the no longer have to worry about cryptographic signing. LMK if you have questions.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ampproject/amphtml/issues/33159#issuecomment-801201554, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEC2FIX3JTHKYA7NWR52BNDTEDGYVANCNFSM4Y3UMELQ .

--

Michael Stevens Senior Developer ▪︎ Dianomi +44 207 802 5530 <+44%20207%20802%205530> @.*** 84 Eccleston Square London, SW1V 1PX www.dianomi.com

-- This e-mail is for the sole use of the intended recipient and contains information that may be privileged and/or confidential. If you are not an intended recipient, please notify the sender by return e-mail and delete this e-mail and any attachments. Certain required legal entity disclosures can be accessed on our website.

calebcordry commented 3 years ago

Sorry that was a bad link. Here is the public version https://docs.google.com/document/d/1UY3PkZmnxgx594-5e-RhZYtnlcKSo6ItgJOJxOBtPVo/edit#

dianomi-mjs commented 3 years ago

@calebcordry @lannka can you give us an update on removing AMPHTML Ad Signing, so we can look at transitioning?

Thank you

calebcordry commented 3 years ago

@dianomi-mjs sorry we tried to launch and had to rollback a couple times now. I sent a PR again yesterday to turn it on so if all goes well it should be ~couple of weeks. I will make sure to update the issue when fully launched. Thanks!

dianomi-mjs commented 3 years ago

@calebcordry thanks for the update!

dianomi-mjs commented 3 years ago

Hi @calebcordry sorry to nag - I take it this is still a little way off? Thanks

calebcordry commented 3 years ago

@dianomi-mjs No-signing is now fully launched! Sorry for the delay on updating.

dianomi-mjs commented 3 years ago

Thanks @calebcordry is there any documentation beyond the design doc above? The demo didn't work for me.

calebcordry commented 3 years ago

@dianomi-mjs just the design doc for now. The general idea is that a valid amphtml ad can now be rendered without needing the cryptographic signing. Let's move this conversation off this thread. I am happy to set up a time to sync about the changes. Feel free to ping me on slack @caleb.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

ampproject / amphtml