ampproject / amphtml

The AMP web component framework.
https://amp.dev
Apache License 2.0
14.89k stars 3.89k forks source link

Streamline package updates for `amphtml` #33959

Open rsimha opened 3 years ago

rsimha commented 3 years ago

Background:

Today, amphtml uses https://github.com/apps/forking-renovate to regularly update all devDependencies (and some dependencies) listed in the root package.json file and various sub-package level files. As of today, there have been close to ~1500 update PRs, all of which have been merged manually. Other than a very small number of breaking changes, all these PRs were rubber-stamp approved and merged after all CI checks were green.

Goal:

The purpose of this issue is to streamline the upgrade process, eliminate unnecessary manual toil, and require human intervention only while approving critical runtime dependencies or addressing breaking changes. This will build on the work done in #28322 to reduce the overall number of upgrade PRs. Here's a proposal:

With this, upgrade PRs for devDependencies that pass all CI checks will be automatically approved and merged.

rsimha commented 3 years ago

@kristoferbaxter @jridgewell @dvoytenko Since y'all are top-level owners, please comment if you have any concerns, and thumbs-up if the plan SGTY.

/cc @ampproject/wg-infra

jridgewell commented 3 years ago

As long as they're devDeps, seems fine.

kristoferbaxter commented 3 years ago

This seems fine to me.

rsimha commented 3 years ago

As long as they're devDeps, seems fine.

Yes, this will be enabled only for renovate groups that cover devDepdendencies, so there's no risk of auto-merging runtime dependencies or having this auto-applied to new groups added in future.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.