Open rsimha opened 3 years ago
@kristoferbaxter @jridgewell @dvoytenko Since y'all are top-level owners, please comment if you have any concerns, and thumbs-up if the plan SGTY.
/cc @ampproject/wg-infra
As long as they're devDeps, seems fine.
This seems fine to me.
As long as they're devDeps, seems fine.
Yes, this will be enabled only for renovate groups that cover devDepdendencies
, so there's no risk of auto-merging runtime dependencies
or having this auto-applied to new groups added in future.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.
Background:
Today,
amphtml
uses https://github.com/apps/forking-renovate to regularly update alldevDependencies
(and somedependencies
) listed in the rootpackage.json
file and various sub-package level files. As of today, there have been close to ~1500 update PRs, all of which have been merged manually. Other than a very small number of breaking changes, all these PRs were rubber-stamp approved and merged after all CI checks were green.Goal:
The purpose of this issue is to streamline the upgrade process, eliminate unnecessary manual toil, and require human intervention only while approving critical runtime dependencies or addressing breaking changes. This will build on the work done in #28322 to reduce the overall number of upgrade PRs. Here's a proposal:
automerge
config setting (see docs)dependencies
(shipped with the runtime)renovate-approve
app to auto-approve PRs that pass CI checksrenovate-approve
as an owner ofpackage.json
andpackage-lock.json
filesWith this, upgrade PRs for
devDependencies
that pass all CI checks will be automatically approved and merged.