wg-performance Status Update 2021-08-16 - Githubissues

ampproject / wg-performance

Monitoring and improving AMP's load and runtime performance for compliant documents. Facilitator: @erwinmombay

Creative Commons Attribution 4.0 International

7 stars 6 forks source link

wg-performance Status Update 2021-08-16 #93

Closed erwinmombay closed 3 years ago

erwinmombay commented 3 years ago

cc @ampproject/wg-performance

What was accomplished

Lessons Learned

What's Next

rcebulko commented 3 years ago

What was accomplished

Expanded import/order throughout src/ & 3p/ (https://github.com/ampproject/amphtml/pull/35226, https://github.com/ampproject/amphtml/pull/35454), test/ & testing/ (https://github.com/ampproject/amphtml/pull/35601), and most of extensions/ (https://github.com/ampproject/amphtml/pull/35649)
Error handling & performance benchmarking for Bento Compiler
Trimmed getMode() object of version (https://github.com/ampproject/amphtml/pull/35624), log (https://github.com/ampproject/amphtml/pull/35628), and geoOverride (https://github.com/ampproject/amphtml/pull/35654) moving logic to only call-sites
#core migration of dev error helpers (https://github.com/ampproject/amphtml/pull/35621) and form+modal+amp-element-helpers (https://github.com/ampproject/amphtml/pull/35608)
Allowlist all #core imports in dep-check-config
https://github.com/ampproject/amphtml/pull/35461
https://github.com/ampproject/amp-github-apps/pull/1452

Lessons Learned

What's Next

Deploy Bento Compiler service for testing
Finish remaining #core migration
Explore using tsc for typechecking

jridgewell commented 3 years ago

What was accomplished

Launched size-adjust experiment: cl/389235307, cl/389746312, cl/389959485
Fixed forbidden terms linting in test files: https://github.com/ampproject/amphtml/pull/35572
Integrated rethrowAsync with test expectations: https://github.com/ampproject/amphtml/pull/35605
Adding type aliases to Babel: https://github.com/babel/babel/pull/13666
Better minification of switch statements in terser: https://github.com/terser/terser/pull/1044

Lessons Learned

Switch statements are much more complex than I initially realized. They are not just if-else statements.

What's Next

Finishing base jolt interpreter evaluation: https://github.com/ampproject/jolt/compare/main...jridgewell:interpreter

erwinmombay commented 3 years ago

amphtml

What was accomplished

add semi transformed document splitting (in progress cl/387682689)

Lessons Learned

What's Next

look into reported performance issues in wg-performance
update amp-geo javascript to handle server side rendering
finish proposal for external stylesheet experiment for render delay

samouri commented 3 years ago

What was accomplished

Distribute CSS files with Bento NPM Packages (https://github.com/ampproject/amphtml/pull/35446)
Brought the I2I for migrating off Closure to design review, have a clear set of next steps
Made ~60% of babel plugins typecheck with tsc (https://github.com/ampproject/amphtml/issues/35573)
Created Jolt Bytecode and tests
Fix LCP/FCP on origin pages: https://github.com/ampproject/amphtml/pull/35533
Small refactor to amp-carousel in preparation for creating a buildDom (https://github.com/ampproject/amphtml/pull/35500)
Tests for buildDom! https://github.com/ampproject/amphtml/pull/35494
♻️ refactor build-system to use the same codepath for both vendor and unminified builds: https://github.com/ampproject/amphtml/pull/35419

What's Next

buildDom for amp-carousel
performance experiment to measure difference in closure and esbuild output
jolt