Closed jrtaylor-com closed 3 years ago
Have left some comments above but otherwise the functionality works. It's a bit weird that you get both a green "Player updated" and the "Image error". Not a big deal though.
@kenwalker I added the spelling mods, and modified the image size text. I kept Bytes since both OSs show bytes when inspecting a file. Converted kilobits to kilobytes.
@kenwalker added officers to kingdom/park index page
Monarchy info on both pages looks good
There are approximately 39 parks (according to the sql query) that have not put http:// or https:// in front of their URL and in that case your link does not work properly. For example, try Felfrost's link.
There are approximately 39 parks (according to the sql query) that have not put http:// or https:// in front of their URL and in that case your link does not work properly. For example, try Felfrost's link.
I feel like once they see the feature they might fix their links. They didn't have a reason to before.
There are approximately 39 parks (according to the sql query) that have not put http:// or https:// in front of their URL and in that case your link does not work properly. For example, try Felfrost's link.
I feel like once they see the feature they might fix their links. They didn't have a reason to before.
I volunteer as tribute to just go fix them ha. I wonder if we could add a validation to the setting of it for any future entries to ensure it has http:// or https:// ?
There are approximately 39 parks (according to the sql query) that have not put http:// or https:// in front of their URL and in that case your link does not work properly. For example, try Felfrost's link.
I feel like once they see the feature they might fix their links. They didn't have a reason to before.
I volunteer as tribute to just go fix them ha. I wonder if we could add a validation to the setting of it for any future entries to ensure it has http:// or https:// ?
I expect a lot of them to be outdated links anyhow. the http/https would be dependent on the host themselves, not on the ORK server. You could replace them with //
instead of https:
or http:
which would just use the ORK's current state. This would keep them from throwing a mixed content error when the ORK is using https.
Only issue would be if the target server doesn't handle switching between http/https gracefully
There are approximately 39 parks (according to the sql query) that have not put http:// or https:// in front of their URL and in that case your link does not work properly. For example, try Felfrost's link.
I feel like once they see the feature they might fix their links. They didn't have a reason to before.
I volunteer as tribute to just go fix them ha. I wonder if we could add a validation to the setting of it for any future entries to ensure it has http:// or https:// ?
I expect a lot of them to be outdated links anyhow. the http/https would be dependent on the host themselves, not on the ORK server. You could replace them with
//
instead ofhttps:
orhttp:
which would just use the ORK's current state. This would keep them from throwing a mixed content error when the ORK is using https.Only issue would be if the target server doesn't handle switching between http/https gracefully
I mean I’ll try them out individually and fix their info.
This file size takes into account the added 1.333 bytes per byte that the base64 encode that is used on the backend adds